[MBL-1229] Add Compose Views for Add-ons screen #1964
Conversation
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #1964 +/- ##
============================================
- Coverage 73.85% 72.75% -1.11%
Complexity 1979 1979
============================================
Files 348 350 +2
Lines 19892 20193 +301
Branches 2755 2802 +47
============================================
Hits 14692 14692
- Misses 3586 3887 +301
Partials 1614 1614 ☔ View full report in Codecov by Sentry. |
mtgriego
added
the
Post Campaign Functionality
app/src/main/java/com/kickstarter/ui/activities/compose/projectpage/AddOnsScreen.kt
Show resolved
Hide resolved
| @Preview(name = "Dark", uiMode = Configuration.UI_MODE_NIGHT_YES) | ||
| private fun AddOnsContainerPreview() { | ||
| KSTheme { | ||
| AddOnsContainer( |
There was a problem hiding this comment.
Not for now, if you guys are in a rush to deliver for project late pledges, but ideally we should start creating re-usable components for these type of cards.
The addOns one could potentially be re-used for rewards in both rewards-carousel and manage pledge screen.
Same for project cards in the future!
There was a problem hiding this comment.
The functionality of the flows are so similar my eventual plan would be to use these screens with whatever copy change we need for the existing flows. iOS is going to be using these in their existing flows. If we had more time I would just refactor all the flows into these screens, but that will be a down the road initiative for sure.
📲 What
Create the composables to be used in the new post campaign add-ons fragment in the flow
🤔 Why
All new things should be done in compose and coroutines and this is a new flow
🛠 How
Took a lot of reference from the existing views and classes to recreate as best as possible
👀 See
Please note colors are not final as I am working with design to review these colors, but they are using as much of the new colors as I could figure out.
Please note that the pricing, shipping, and some other functionality of the page needs an environment to parse our current strings so they wont show up in the preview
📋 QA
This will come more strongly during implementation, the container works as expected in the preview, but the acreen needs an environment to fully function so some functionality seems wonky without it.
Story 📖
MBL-1229