Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MBL-1164] Add post campaign fields to project queries/mutations #1965

Merged
merged 1 commit into from
Mar 4, 2024

Conversation

mtgriego
Copy link
Contributor

@mtgriego mtgriego commented Feb 29, 2024

📲 What

Add two fields to the project model in graphql and in app:
-isPostCampaignEnabled
-postCampaignPledgingEnabled

🤔 Why

These fields will be used to determine if the campaign will be allowed to go into the post campaign flow (only if both are true)

🛠 How

Added the fields to the fragments for graph, added them to the model for app model

📋 QA

Check the logs on staging for these fields:
(Look up the project Baconbaconbacon on staging for a true result)
"isInPostCampaignPledgingPhase":true,"postCampaignPledgingEnabled":true,
(Most projects will be false as its not enabled creator side yet)
"isInPostCampaignPledgingPhase":false,"postCampaignPledgingEnabled":false,

Story 📖

MBL-1164

@mtgriego mtgriego added the Post Campaign Functionality Tied to Epic https://kickstarter.atlassian.net/browse/MBL-1108 label Feb 29, 2024
@mtgriego mtgriego self-assigned this Feb 29, 2024
@mtgriego mtgriego marked this pull request as ready for review February 29, 2024 21:17
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 85.71429% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 73.85%. Comparing base (2e0818f) to head (5244001).

Files Patch % Lines
...pp/src/main/java/com/kickstarter/models/Project.kt 85.71% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1965      +/-   ##
============================================
- Coverage     73.85%   73.85%   -0.01%     
+ Complexity     1979     1978       -1     
============================================
  Files           348      348              
  Lines         19892    19903      +11     
  Branches       2755     2755              
============================================
+ Hits          14692    14699       +7     
- Misses         3586     3589       +3     
- Partials       1614     1615       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mtgriego mtgriego merged commit 78f81ff into master Mar 4, 2024
3 checks passed
@mtgriego mtgriego deleted the mgriego/MBL-1164 branch March 4, 2024 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Post Campaign Functionality Tied to Epic https://kickstarter.atlassian.net/browse/MBL-1108
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants