Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MBL-1227] Add post campaign messaging for project page #1967

Merged
merged 5 commits into from
Mar 5, 2024

Conversation

mtgriego
Copy link
Contributor

@mtgriego mtgriego commented Mar 4, 2024

📲 What

Add the new messaging for when a project is collecting post campaign pledges to the project page

🤔 Why

The people need to know

🛠 How

Added a new string (translations needed) and populated based on project flags

👀 See

Screenshot_20240304-132659

📋 QA

  1. Go to successful projects to see if the correct messaging shows up (not post campaign collecting message)
  2. On staging go to the Baconbaconbacon project and confirm this is showing up correctly

Story 📖

MBL-1227

@mtgriego mtgriego added UI 🎨 Post Campaign Functionality Tied to Epic https://kickstarter.atlassian.net/browse/MBL-1108 labels Mar 4, 2024
@mtgriego
Copy link
Contributor Author

mtgriego commented Mar 4, 2024

I also had to add the builder fields for these to be properly populated on the project page

@mtgriego mtgriego marked this pull request as ready for review March 4, 2024 21:34
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 25.00000% with 9 lines in your changes are missing coverage. Please review.

Project coverage is 73.83%. Comparing base (78f81ff) to head (041a07d).

Files Patch % Lines
...arter/services/transformers/GraphQLTransformers.kt 0.00% 4 Missing ⚠️
...viewmodels/projectpage/ProjectOverviewViewModel.kt 50.00% 2 Missing and 1 partial ⚠️
...pp/src/main/java/com/kickstarter/models/Project.kt 0.00% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1967      +/-   ##
============================================
- Coverage     73.85%   73.83%   -0.03%     
- Complexity     1979     1981       +2     
============================================
  Files           348      348              
  Lines         19903    19915      +12     
  Branches       2755     2760       +5     
============================================
+ Hits          14700    14704       +4     
- Misses         3589     3596       +7     
- Partials       1614     1615       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@Arkariang Arkariang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test!

@mtgriego mtgriego merged commit f6c5d30 into master Mar 5, 2024
3 checks passed
@mtgriego mtgriego deleted the mgriego/MBL-1227 branch March 5, 2024 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Post Campaign Functionality Tied to Epic https://kickstarter.atlassian.net/browse/MBL-1108 UI 🎨
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants