Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MBL-1251 get create attribution event graphqltransformer #1969

Conversation

ycheng-kickstarter
Copy link
Contributor

πŸ“² What

This PR is for step 4 of https://kickstarter.atlassian.net/wiki/spaces/NT/pages/2699100255/Event+Attribution+Engineering+Plan+AKA+How+To+Wire+Up+a+New+GraphQL+Endpoint+on+Android

πŸ€” Why

CreateAttributionEventData is the corresponding internal data model to the GraphQL model [CreateAttributionEventInput]. This transformer converts CreateAttributionEventData β†’ CreateAttributionEventInput β†’ CreateAttributionEventMutation for the Apollo client to use

πŸ›  How

More in-depth discussion of the change or implementation.

πŸ‘€ See

Trello, screenshots, external resources?

Before πŸ› After πŸ¦‹

πŸ“‹ QA

Instructions for anyone to be able to QA this work.

Story πŸ“–

https://kickstarter.atlassian.net/browse/MBL-1251

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 10 lines in your changes are missing coverage. Please review.

Project coverage is 72.69%. Comparing base (f6c5d30) to head (f214732).

Files Patch % Lines
...arter/services/transformers/GraphQLTransformers.kt 0.00% 10 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1969      +/-   ##
============================================
- Coverage     72.73%   72.69%   -0.04%     
  Complexity     1980     1980              
============================================
  Files           350      350              
  Lines         20220    20230      +10     
  Branches       2808     2808              
============================================
  Hits          14707    14707              
- Misses         3894     3904      +10     
  Partials       1619     1619              

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

@ycheng-kickstarter ycheng-kickstarter merged commit 9f17a55 into master Mar 6, 2024
3 checks passed
@ycheng-kickstarter ycheng-kickstarter deleted the MBL-1251-getCreateAttributionEvent-graphqltransformer branch March 6, 2024 14:47
@ycheng-kickstarter ycheng-kickstarter self-assigned this Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants