Creator tools rewards #206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-Some spacing in the header layout. -Progress bar color based on project state with mad tests.
-javadoc -tests -cleanup
# Conflicts: # app/src/main/res/layout/dashboard_funding_view.xml
# Conflicts: # app/src/main/java/com/kickstarter/ui/viewholders/CreatorDashboardHeaderViewHolder.java # app/src/main/java/com/kickstarter/viewmodels/CreatorDashboardHeaderHolderViewModel.java # app/src/main/res/layout/dashboard_funding_view.xml # app/src/test/java/com/kickstarter/viewmodels/CreatorDashboardHeaderHolderViewModelTest.java
… we don't discard stats with the same amount pledged.
…ess than 10, not the truncated one
# Conflicts: # app/src/test/java/com/kickstarter/viewmodels/CreatorDashboardHeaderHolderViewModelTest.java
Rcureton
pushed a commit
that referenced
this pull request
Jul 31, 2018
* Creator tools reward design implementation and tests. * When sorting the reward stats, we should keep a list and not a set so we don't discard stats with the same amount pledged.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what 🤔
Check out the latest and greatest designs of the creator tools dashboard rewards table. And tests!
I am holding off on copy and including the reward title for speed purposes 🏃♀️
l👁👁k