Creator tools tracking #213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-added ref tag for messages -added events for `Viewed Project Dashboard`, `Opened Project Switcher` and `Switched Projects`
Scollaco
reviewed
Feb 21, 2018
| @@ -51,6 +51,10 @@ public ViewModel(final @NonNull Environment environment) { | |||
| .compose(bindToLifecycle()) | |||
| .subscribe(this.projectAndStats); | |||
|
|
|||
| this.projectsMenuClick | |||
There was a problem hiding this comment.
Could we rename this to projectList instead? It would make more sense on the context of the app.
Scollaco
reviewed
Feb 21, 2018
| .take(1) | ||
| .compose(bindToLifecycle()) | ||
| .subscribe(__ -> this.koala.trackViewedMailbox(Mailbox.INBOX, null)); | ||
| .subscribe(data -> this.koala.trackViewedMailbox(Mailbox.INBOX, data.first, data.second)); |
There was a problem hiding this comment.
Could you rename this for project and refTag instead of data?
Scollaco
approved these changes
Feb 21, 2018
-renaming
-forgot to rename one more thing
Rcureton
pushed a commit
that referenced
this pull request
Jul 31, 2018
* Creator tools tracking/instrumentation! -added ref tag for messages -added events for `Viewed Project Dashboard`, `Opened Project Switcher` and `Switched Projects` * updating tests * PR feedback: -renaming
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creator tools tracking/instrumentation!
-refactoring
CreatorDashboardViewModeland tests-added ref tag for messages
-added events for
Viewed Project Dashboard,Opened Project SwitcherandSwitched Projects