creator tools strings #215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eoji
commented
Feb 21, 2018
| @@ -31,4 +31,13 @@ public void testIsPresent() { | |||
| assertTrue(StringUtils.isPresent("a")); | |||
| assertTrue(StringUtils.isPresent(" a ")); | |||
| } | |||
|
|
|||
| @Test | |||
| public void testSentenceCase() { | |||
There was a problem hiding this comment.
Let's add a test for the single and empty cases.
| @@ -50,10 +54,14 @@ public CreatorDashboardReferrerStatsViewHolder(final @NonNull View view) { | |||
| .compose(observeForUI()) | |||
| .subscribe(this::toggleRecyclerViewAndEmptyStateVisibility); | |||
|
|
|||
| this.viewModel.outputs.referrerStatsTruncatedTextIsGone() | |||
| this.viewModel.outputs.referrersTitleIsLimitedCopy() | |||
There was a problem hiding this comment.
Let's rename to referrersTitleHasTopTen
| @@ -56,6 +62,16 @@ public CreatorDashboardRewardStatsViewHolder(final @NonNull View view) { | |||
| .compose(bindToLifecycle()) | |||
| .compose(observeForUI()) | |||
| .subscribe(gone -> ViewUtils.setGone(this.truncatedTextView, gone)); | |||
|
|
|||
| this.viewModel.outputs.rewardsTitleIsLimitedCopy() | |||
-renaming -adding more test cases
Rcureton
pushed a commit
that referenced
this pull request
Jul 31, 2018
* creator tools strings updates with tests for title changes * sentence casing top rewards string with tests * PR feedback: -renaming -adding more test cases
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
Updating creator tools strings and tests.
see