Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

project share intent #217

Merged
merged 3 commits into from
Feb 23, 2018
Merged

project share intent #217

merged 3 commits into from
Feb 23, 2018

Conversation

eoji
Copy link
Contributor

@eoji eoji commented Feb 23, 2018

what

Updating how we share projects because Samsung ruins everything.

why

We've gotten some Android feedback about users not being able to choose a different app to share projects. On Samsung devices, once you share a project via say Facebook, you get defaulted to sharing via Facebook and you have to reset app defaults to reset it. We should be using this way to share anyway, not sure why the project screen was different.

how

Here are the docs on it: https://developer.android.com/training/sharing/send.html

before and after

@eoji eoji requested a review from Scollaco February 23, 2018 15:43
Copy link
Contributor

@Scollaco Scollaco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! 👍

@eoji eoji merged commit e07c9c0 into master Feb 23, 2018
@eoji eoji deleted the share-intent branch February 23, 2018 18:21
Rcureton pushed a commit that referenced this pull request Jul 31, 2018
* Updating how we share projects by using Intent.createChooser()
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants