ReferrerType update #222
Merged
ReferrerType update #222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ernal"]` as referral types so we don't need to check for campaign and domain.
Scollaco
approved these changes
Mar 9, 2018
Rcureton
pushed a commit
that referenced
this pull request
Jul 31, 2018
the server will now only be returning `["kickstarter", "custom", "external"]` as referral types so we don't need to check for campaign and domain. (#222)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
The server will now only be returning
["kickstarter", "custom", "external"]as referral types so we don't need to check for campaign and domain. Check out this PR https://github.com/kickstarter/kickstarter/pull/9962 for reference.@Scollaco @cdolm92 it's not necessary for iOS to make this change but it affected my chart work in the #221 PR (basically I have no corresponding colors for
["campaign", "domain"]so I removed them).