creator-tools-collab-bug #226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…with tests. Updated tests with creators so we don't miss any collaborators. Added a helper User that is a collaborator and not a creator.
eoji
commented
Mar 21, 2018
| this.vm.inputs.projectAndStats(Pair.create(ProjectFactory.project(), ProjectStatsEnvelopeFactory.projectStatsEnvelope())); | ||
|
|
||
| this.otherProjectsButtonIsGone.assertValues(true); | ||
| } | ||
|
|
||
| @Test | ||
| public void testOtherProjectsButtonIsGone_WhenCreatorHasManyProjects() { | ||
| final CurrentUserType creator = new MockCurrentUser(UserFactory.creator()); | ||
| public void testOtherProjectsButtonIsGone_WhenCollaboratorHasManyProjects() { |
There was a problem hiding this comment.
Update test name testOtherProjectsButtonIsGone_isFalse_WhenCollaboratorHasManyProjects
| public void testOtherProjectsButtonIsGone_WhenCreatorHas1Project() { | ||
| final User creatorWith1Project = UserFactory.creator().toBuilder().createdProjectsCount(1).build(); | ||
| final CurrentUserType creator = new MockCurrentUser(creatorWith1Project); | ||
| public void testOtherProjectsButtonIsGone_WhenCollaboratorHas1Project() { |
There was a problem hiding this comment.
Update test name testOtherProjectsButtonIsGone_isTrue_WhenCollaboratorHas1Project
| @@ -75,7 +75,7 @@ public void testCreatorDashboardButtonIsGone__notCreatorOrCollaborator() { | |||
| } | |||
|
|
|||
| @Test | |||
| public void testCreatorDashboardButtonIsGone__isCreatorOrCollaborator() { | |||
| public void testCreatorDashboardButtonIsGone__isCreator() { | |||
There was a problem hiding this comment.
Update test name to testCreatorDashboardButtonIsGone_isFalse_WhenCreator
| @@ -88,6 +88,20 @@ public void testCreatorDashboardButtonIsGone__isCreatorOrCollaborator() { | |||
| this.creatorDashboardButtonIsGone.assertValues(false); | |||
| } | |||
|
|
|||
| @Test | |||
| public void testCreatorDashboardButtonIsGone__isCollaborator() { | |||
There was a problem hiding this comment.
Update test name to testCreatorDashboardButtonIsGone_isFalse_WhenCollaborator
Scollaco
approved these changes
Mar 21, 2018
Rcureton
pushed a commit
that referenced
this pull request
Jul 31, 2018
* Showing more projects button for collaborators and not just creators with tests. Updated tests with creators so we don't miss any collaborators. Added a helper User that is a collaborator and not a creator.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
Collaborators were not seeing the "Select another project" button because we were checking
created_projects_countand notmember_projects_count.Did an audit of where
User.creatoris used so we don't miss any collaborators.Added a helper User that is a collaborator and not a creator.
see
As a collaborator of 2 projects and no created projects, I see the "Select another project" button.
