hd vids #228
Merged
hd vids #228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deleting unused code
…ocking or actually using real android src. Updated VideoViewModel tests.
eoji
commented
Mar 21, 2018
| this.loadingIndicatorProgressBar.setVisibility(View.GONE); | ||
| } | ||
| } | ||
|
|
||
| private void releasePlayer() { |
There was a problem hiding this comment.
Move this to the bottom with the other private methods.
| @TargetApi(19) | ||
| private boolean isMediaControllerAttachedToWindow() { | ||
| return ApiCapabilities.canCheckMediaControllerIsAttachedToWindow() && this.mediaController.isAttachedToWindow(); | ||
| private String getUserAgent() { |
There was a problem hiding this comment.
To not have repeat code, let's make a static helper method in WebRequestInterceptor so that we can reuse whenever we need a user agent
| // Configure the view model with a project intent. | ||
| vm.intent(new Intent().putExtra(IntentKey.PROJECT, project)); | ||
|
|
||
| preparePlayerWithUrl.assertValues(project.video().hls()); |
There was a problem hiding this comment.
We should use assertValue instead and in the second test
Rcureton
pushed a commit
that referenced
this pull request
Jul 31, 2018
Upgrading ExoPlayer to 2.7.0 and supporting HLS videos.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
Supporting HD videos.
how
Updating ExoPlayer to 2.7.0 and checking for HLS videos.
Removing some custom code that we had.
see
Run this build on a device 🤓