Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

marking rewards as received #234

Merged
merged 8 commits into from
Apr 3, 2018
Merged

marking rewards as received #234

merged 8 commits into from
Apr 3, 2018

Conversation

eoji
Copy link
Contributor

@eoji eoji commented Mar 30, 2018

what

Backers should be able to mark their rewards as received.
Cleaning up the layout.

see

jw

Am I writing too many tests?

@eoji
Copy link
Contributor Author

eoji commented Mar 30, 2018

Copy link
Contributor

@Scollaco Scollaco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome job, @eoji ! I just have a comment.


projectAndBacking
.compose(takePairWhen(this.markAsReceivedSwitchChecked))
.switchMap(triple -> this.client.postBacking(triple.first.first, triple.first.second, triple.second))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a way to make this line more readable? I think that using triple, first and second is a little bit too generic to understand what's going on.

@eoji eoji merged commit 102584e into master Apr 3, 2018
@eoji eoji deleted the got-it branch April 3, 2018 20:50
Rcureton pushed a commit that referenced this pull request Jul 31, 2018
Backers should be able to mark their rewards as received.
With tests!
@eoji eoji mentioned this pull request Jun 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants