-
Notifications
You must be signed in to change notification settings - Fork 991
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
marking rewards as received #234
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome job, @eoji ! I just have a comment.
|
||
projectAndBacking | ||
.compose(takePairWhen(this.markAsReceivedSwitchChecked)) | ||
.switchMap(triple -> this.client.postBacking(triple.first.first, triple.first.second, triple.second)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a way to make this line more readable? I think that using triple
, first
and second
is a little bit too generic to understand what's going on.
Backers should be able to mark their rewards as received. With tests!
what
Backers should be able to mark their rewards as received.
Cleaning up the layout.
see
jw
Am I writing too many tests?