[wip] backend funnel fix #235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nstance().getId()`
eoji
commented
Apr 9, 2018
|
|
||
| private void setVisitorCookie() { | ||
| final String deviceId = InstanceID.getInstance(this).getId(); | ||
| final String uuid = TextUtils.isEmpty(deviceId) ? UUID.randomUUID().toString() : deviceId; |
There was a problem hiding this comment.
rename to uniqueIdentifier
| } | ||
|
|
||
| private Optional<HttpCookie> getOptionalVisitorCookieForURI(final @NonNull CookieStore cookieStore, final @NonNull URI webUri) { | ||
| // it's problematic, i know |
| final HttpCookie webCookie = webVisCookie.get(); | ||
| final HttpCookie apiCookie = apiVisCookie.get(); | ||
|
|
||
| Assert.assertNotNull(webCookie); |
There was a problem hiding this comment.
instead of asserting they aren't null, assert that cookie.isPresent()
Rcureton
pushed a commit
that referenced
this pull request
Jul 31, 2018
* attempting to have unique tracking ids, switching to `InstanceId.getInstance().getId()` and our first instrumentation test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
We should be setting the visitor cookie on web and api. The value is
InstanceId.getInstance().getId(). Read more about it here -> https://developer.android.com/training/articles/user-data-ids.html.I also added our first instrumentation test ✨ but I'm doing some gross stuff with optionals so I'm open to feedback. (Cookies are returned as a list and not a map because 2 cookies can have the same name, party time.)
Shout out to @ryanpeterson for pairing on this with me for many moons.