Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

home to magic 馃帺 #240

Merged
merged 1 commit into from
Apr 20, 2018
Merged

home to magic 馃帺 #240

merged 1 commit into from
Apr 20, 2018

Conversation

eoji
Copy link
Contributor

@eoji eoji commented Apr 19, 2018

what

Home sort is now Magic sort.

why

For fun.

before and after 馃憖

@eoji eoji requested a review from Scollaco April 19, 2018 22:04
@eoji
Copy link
Contributor Author

eoji commented Apr 19, 2018

Change home to magic

@Scollaco
Copy link
Contributor

GIF

Scollaco
Scollaco approved these changes Apr 20, 2018
View reviewed changes
Copy link
Contributor

@Scollaco Scollaco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job, @eoji ! It's magical!

@panmona
Copy link

panmona commented Apr 20, 2018

Makes sense for me as a user 馃憤

@eoji eoji merged commit 66c264b into master Apr 20, 2018
@eoji eoji deleted the home-to-magic branch April 20, 2018 21:15
Rcureton pushed a commit that referenced this pull request Jul 31, 2018
@eoji
home to magic and a typo fix (#240)
7ea0861
@eoji eoji mentioned this pull request Jan 25, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Scollaco Scollaco Scollaco approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@eoji @Scollaco @panmona