[GDPR] Sign up newsletter opt out #242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Scollaco
reviewed
Apr 25, 2018
| @@ -98,12 +98,12 @@ public void testToggleSendNewsLetter_ForUSUser() { | |||
| this.vm = new FacebookConfirmationViewModel.ViewModel(environment); | |||
|
|
|||
| this.vm.outputs.sendNewslettersIsChecked().subscribe(this.sendNewslettersIsChecked); | |||
| this.sendNewslettersIsChecked.assertValue(true); | |||
| this.sendNewslettersIsChecked.assertValue(false); | |||
There was a problem hiding this comment.
I would change the name of the test to something like testToggleSendNewsLetter_isNotChecked, since now we don't differenciate the toggle status for US/Non-US users.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
Opting out of the newsletter on sign up and Facebook confirmation screens.
Updating tests.
why