Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Account deletion #247

Merged
merged 11 commits into from
May 23, 2018
Merged

Account deletion #247

merged 11 commits into from
May 23, 2018

Conversation

Scollaco
Copy link
Contributor

@Scollaco Scollaco commented May 11, 2018

What

Added an extra row for account deletion.

Why

GDPR!

See

GIF

@eoji
Copy link
Contributor

eoji commented May 22, 2018

New looks wuttup
2018-05-22 11_58_41

@dannyalright

@eoji
Copy link
Contributor

eoji commented May 22, 2018

This PR depends on #254, so please review so we can close this one 🙏

Copy link

@ifbarrera ifbarrera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! ✔️

# Conflicts:
#	app/src/main/res/layout/settings_layout.xml
@eoji eoji removed the WIP 🔨 label May 23, 2018
@eoji eoji merged commit 26d5ae6 into master May 23, 2018
@eoji eoji deleted the delete_account branch May 23, 2018 16:40
@eoji
Copy link
Contributor

eoji commented May 23, 2018

@eoji
Copy link
Contributor

eoji commented May 23, 2018

Rcureton pushed a commit that referenced this pull request Jul 31, 2018
Rcureton pushed a commit that referenced this pull request Jul 31, 2018
* Added row for account deletion

* checkstyle

* Linking externally to the account deletion page.

* moving strings and adding deletion to privacy section

* merged in the settings ui branch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants