Login Tout & Sign Up, GDPR style #249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
does this PR also affect the sign-up screen, like iOS? |
|
@dannyalright also the facebook confirmation page |
|
@dannyalright @eoji yep, affects all three on iOS as well. So much text 😓 |
|
@dannyalright added the sign up screenshot! |
# Conflicts: # app/src/main/assets/json/server-config.json # app/src/main/res/values-es/strings_i18n.xml # app/src/main/res/values-fr/strings_i18n.xml # app/src/main/res/values-ja/strings_i18n.xml
…why do we have them?!?!!?)
|
One more screenshot @dannyalright |
Rcureton
pushed a commit
that referenced
this pull request
Jul 31, 2018
* second pass of discovery and project refresh
Rcureton
pushed a commit
that referenced
this pull request
Jul 31, 2018
* updating the strings and login tout copy * new strings broke my other views so i am combining PRs * updating landscape login tout copy and updating the italian strings (why do we have them?!?!!?)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
Updating the strings from the server.
Removing Facebook copy.
Updating the disclaimer.
why
|￣￣￣￣￣￣|
| G |
| D |
| P |
| R |
| ＿＿＿＿＿__|
(\ _ /) ||
(•ㅅ•) ||
/ づ
see
cc @dannyalright @nnekab