Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GDPR] messages opt out #253

Merged
merged 2 commits into from
May 22, 2018
Merged

[GDPR] messages opt out #253

merged 2 commits into from
May 22, 2018

Conversation

eoji
Copy link
Contributor

@eoji eoji commented May 21, 2018

what

opting out of receiving message push notifications

why

GIF

how

We have 2 new properties on the User model, notifyMobileOfMessages and notifyOfMessages.

see

Copy link

@ifbarrera ifbarrera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! 👍

@eoji eoji merged commit c91c860 into master May 22, 2018
@eoji eoji deleted the messages-opt branch May 22, 2018 14:56
@eoji
Copy link
Contributor Author

eoji commented May 22, 2018

@eoji
Copy link
Contributor Author

eoji commented May 22, 2018

1 similar comment
@eoji
Copy link
Contributor Author

eoji commented May 22, 2018

Rcureton pushed a commit that referenced this pull request Jul 31, 2018
* started thanks page refresh

* Merge branch 'master' of github.com:kickstarter/android-private into thanks-refresh

# Conflicts:
#	app/src/main/java/com/kickstarter/ui/fragments/DiscoveryFragment.java
#	app/src/main/java/com/kickstarter/ui/toolbars/DiscoveryToolbar.java

* Move intent mapper helper to utils class

* Overhaul Thanks architecture for new design

* Start ProjectActivity from the ProjectCardViewHolder

* cleanup and update new VH with tests

* Revert starting ProjectActivity from card VH

the reftag logic is better done in the appropriate viewmodels

* re-hook up Category card click

* quality

* add propject props to project click koala event

* hook up share social buttons

* fix margin

* fix adapter loading on rotation; more margin tweaking

* Fix tests: view holder is configured via input rather than Intent

* update to use bindToLifecycle()

* update category card with CTA button

* Use Buttons for share buttons; PR feedback

* final margin tweaking
Rcureton pushed a commit that referenced this pull request Jul 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants