Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating help center link #258

Merged
merged 5 commits into from
Jun 7, 2018
Merged

Updating help center link #258

merged 5 commits into from
Jun 7, 2018

Conversation

eoji
Copy link
Contributor

@eoji eoji commented May 29, 2018

what

Updating help center link!
It follows the same pattern as our other help links.

why

@walterbm said so

see how cute

@@ -30,8 +30,9 @@
public static final int HELP_TYPE_HOW_IT_WORKS = 2;
public static final int HELP_TYPE_COOKIE_POLICY = 3;
public static final int HELP_TYPE_FAQ = 4;
Copy link
Contributor

@Scollaco Scollaco May 30, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HELP_TYPE_HELP_CENTER is replacing HELP_TYPE_FAQ, so we wouldn't need both here.

@eoji
Copy link
Contributor Author

eoji commented Jun 1, 2018

@nnekab @Scollaco @walterbm Made those changes.

Here's the updated gif:
2018-06-01 14_47_26

@eoji
Copy link
Contributor Author

eoji commented Jun 1, 2018

@eoji
Copy link
Contributor Author

eoji commented Jun 5, 2018

made more changes due to an issue with the webview ༼ ༎ຶ ෴ ༎ຶ༽ We are now linking ✨externally ✨in both settings and the Login/Sign up helper menu

cc @walterbm
2018-06-05 15_57_02

Copy link

@ifbarrera ifbarrera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@eoji eoji merged commit bd7d98f into master Jun 7, 2018
@eoji eoji deleted the hc-pt-2 branch June 7, 2018 18:47
Rcureton pushed a commit that referenced this pull request Jul 31, 2018
eoji pushed a commit that referenced this pull request Aug 31, 2018
* Match CircleCI config to HEAD & add caching to alpha

* Run all container jobs in mounted `/usr/local/test`

* Update cache key and steps

* Set home directory and project directories to match

* Change shared $HOME directory to /home/build and bump cache keys

* Change shared $HOME directory to /home/

* Remove working_directory and set HOME to /home/build/
- hope to avoid ssh / git config errors...

* Try build job in CircleCI container

* Consolidate package install under new sdkmanager CLI
- `android` CLI is deprecated

* Remove Android sdkmanager dependency installation
- circleci image preinstalls it

* Remove unused commands and use circleci/android image in tests

* Cache google-services.json files

* Bump cache key version to store new paths

* Pass secrets in CircleCI workspaces
- bump cache key version to 4

* Update google-services glob

* Move persist_to_workspace directive to after its paths are generated

* Set default working directory for build and test steps

* Update glob for workspace JSON credentials

* Fix filepath glob

* Try to pass the entire app/ directory through workspace

* Match CircleCI config to HEAD & add caching to alpha

* Run all container jobs in mounted `/usr/local/test`

* Update cache key and steps

* Set home directory and project directories to match

* Change shared $HOME directory to /home/build and bump cache keys

* Change shared $HOME directory to /home/

* Remove working_directory and set HOME to /home/build/
- hope to avoid ssh / git config errors...

* Try build job in CircleCI container

* Consolidate package install under new sdkmanager CLI
- `android` CLI is deprecated

* Remove Android sdkmanager dependency installation
- circleci image preinstalls it

* Remove unused commands and use circleci/android image in tests

* Cache google-services.json files

* Bump cache key version to store new paths

* Pass secrets in CircleCI workspaces
- bump cache key version to 4

* Update google-services glob

* Move persist_to_workspace directive to after its paths are generated

* Set default working directory for build and test steps

* Update glob for workspace JSON credentials

* Fix filepath glob

* Try to pass the entire app/ directory through workspace

* Persist all updated files in workspace

* Clean up CircleCI file and revert test blocks

* Re-add mistakenly removed .android directory to CircleCI cache
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants