Toggling following in settings #259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ifbarrera
reviewed
Jun 7, 2018
|
|
||
| this.optOutOfFollowing | ||
| .compose(bindToLifecycle()) | ||
| .filter(optOut -> !optOut) |
There was a problem hiding this comment.
I'm not sure if it might make sense to consolidate these two subscribers into one:
.subscribe(optOut ->
if (optOut) {
this.userInput.onNext(this.userOutput.getValue().toBuilder().social(false).build())
} else {
this.hideConfirmFollowingOptOutPrompt.onNext(null)
})
There was a problem hiding this comment.
I'm glad you called this out because I had it that way and changed it. What do you think is best? I was trying to avoid doing an if/else because it's not very functional 馃槶but then this way is not very readable.
There was a problem hiding this comment.
Yeah I thought there might have been a reason you went this way. I'm ok with it, just wanted to see the thinking behind it! Thanks! 猸愶笍
ifbarrera
approved these changes
Jun 7, 2018
Rcureton
pushed a commit
that referenced
this pull request
Jul 31, 2018
eoji
added a commit
that referenced
this pull request
Feb 4, 2019
* Add CloudFormation for CircleCI user * Fix indentation on CloudFormation template * Add GetObject to CI user
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
Users should be able to toggle whether or not they can be following or
socialvia settings. This change also updates whether theBacked by people you followsection is visible in the drawer.This is a destructive change so we need to confirm they definitely want to do this.
why
G
D
P
R
how 馃
The
optIntoFollowinginput determines whether user has checked the switch on or off. TheoptOutOfFollowinginput determines whether user has confirmed turning Following off.When
optIntoFollowingistrue, we just turn Following on.When
optIntoFollowingisfalse, we show the confirmation dialog. This dialog is not cancelable, Iexpectdemand, they make a choice!When
optOutOfFollowingistrue, that's a confirmation, we turn Following off.When
optOutOfFollowingisfalse, we change the switch back to on!see 馃憖
First, I'm
socialand my drawer showsBacked by people you follow. I attempt to turn it off, cancel. I attempt to turn it off again, and confirm. My drawer no longer showsBacked by people you follow.