fixing broken videos and images on 19 and below #260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…8/18. Android versions 19 and below don't have TLS 1.2 enabled by default 😐 This change uses Google Play Services to patch Android's security provider, it's lit. I'm removing the work Lisa did to enable TLS on 19 > devices because it was only on Retrofit, we have external dependencies that make network calls including Picasso (I think uses Okhttp) and ExoPlayer. This needs to be a global change.
ifbarrera
approved these changes
Jun 7, 2018
Closed
Rcureton
pushed a commit
that referenced
this pull request
Jul 31, 2018
* TLS 1.0 and 1.1 is no longer supported on our image host starting 5/18/18. Android versions 19 and below don't have TLS 1.2 enabled by default This change uses Google Play Services to patch Android's security provider! I'm removing the work Lisa did to enable TLS on 19 > devices because it was only on Retrofit, we have external dependencies that make network calls including Picasso (I think uses Okhttp) and ExoPlayer. This needs to be a global change. * We also need to update the Makefile since we're not copying over those files anymore.
eoji
added a commit
that referenced
this pull request
Feb 11, 2019
* wip s3 upload * Revert aws-sdk to 2.11 for fastlane-plugin-aws_s3 * Reverting version code back to being bumped by milkrun. Updated internal lane to upload to s3 (circleci needs creds). Cleaned up Fastfile. Created internal job. * checking build output location * making build and printing output path * I don't think we need to get the path from milkrun since we can get it from fastlane * woops need to specify the audience * pulling s3 configs from env or from config * specifying build type * No longer automatically creating alphas.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what, why, how
TLS 1.0 and 1.1 is no longer supported on our image host starting 5/18/18. https://blog.imgix.com/2018/05/18/tls-deprecation.html
Android versions 19 and below don't have TLS 1.2 enabled by default 😐 So videos and images are currently broken for all users on 19 and below 😢
This change uses Google Play Services to patch Android's security provider, it's lit 👏
Shout out to this StackOverflow answer: https://stackoverflow.com/questions/29916962/javax-net-ssl-sslhandshakeexception-javax-net-ssl-sslprotocolexception-ssl-han/36892715#36892715
I'm removing the work Lisa did to enable TLS on 19 > devices because it was only on Retrofit, we have external dependencies that make network calls including Picasso (I think uses Okhttp) and ExoPlayer. This needs to be a global change.
before & after