Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENHANCE ✨Smooth scrolling to the top of the disco fragment when reselecting a tab. #335

Merged
merged 1 commit into from
Sep 13, 2018
Merged

ENHANCE ✨Smooth scrolling to the top of the disco fragment when reselecting a tab. #335

merged 1 commit into from
Sep 13, 2018

Conversation

eoji
Copy link
Contributor

@eoji eoji commented Sep 13, 2018

what

Smooth scrolling to the top of the Disco fragment when a tab is reselected.

how

Added a TabSelectedListener to the TabLayout and onTabReselected, letting the DiscoveryPagerAdapter know the current fragment needs to scroll to the top.

see

2018-09-13 18_12_55

@eoji eoji requested a review from Rcureton September 13, 2018 22:13
Rcureton
Rcureton approved these changes Sep 13, 2018
View reviewed changes
Copy link
Contributor

@Rcureton Rcureton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice amazing cool feature!!!! Our users are going to love it

@eoji eoji merged commit 3f88a8d into master Sep 13, 2018
@eoji eoji deleted the io/tap-to-scroll branch September 13, 2018 23:27
@dnywh
Copy link
Contributor

dnywh commented Sep 14, 2018

boom

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rcureton Rcureton Rcureton approved these changes

Assignees
No one assigned
Labels
feature ✨
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@eoji @dnywh @Rcureton