[POC] Mutations? ✅ Custom scalar support? ✅ #336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added adapter for Email custom scalar. In the `TestApolloActivity`, logged in users can now update their email addresses.
Rcureton
approved these changes
Sep 14, 2018
| update_email.text = "Update email" | ||
| update_email.setOnClickListener { | ||
| this.viewModel.inputs.updateEmailClicked(new_email.text(), current_password.text()) | ||
| clearNameAndEmail() |
There was a problem hiding this comment.
I see you using that extension 😏
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
Added a POC for custom scalars.
Added adapter for Email custom scalar.
In the
TestApolloActivity, logged in users can now update their email addresses.how sway
Added
Email, defined as ajava.lang.StringtocustomTypeMappinginbuild.gradle.Added adapter for encoding and decoding
EmailinEmailAdapter. Should we do some validation here? It happens server side.Added mutation for
UpdateUserEmailthat takes inemailandcurrent_password.Updated
TestApolloActivityto actually make this call.Shouts to @orionmcc for support!