-
Notifications
You must be signed in to change notification settings - Fork 992
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Enhancement] - Currency picker alert #350
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2 small non blocking pieces of feedback
1 woohoo!
<item name="colorAccent">@color/text_secondary</item> | ||
</style> | ||
|
||
<style name="AlertDialogButtonStyle" parent="Widget.AppCompat.Button.ButtonBar.AlertDialog"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sweet!
app/src/main/res/values/styles.xml
Outdated
</style> | ||
|
||
<style name="AlertDialogButtonStyle" parent="Widget.AppCompat.Button.ButtonBar.AlertDialog"> | ||
<item name="android:textColor">@color/ksr_green_500</item> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we refer to this is colorAccent
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So it was ignoring the color when I used colorAccent so I went with TextColor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I wasn't clear. I mean the color value you're passing in. Like this <item name="android:textColor">@color/accent</item>
android:layout_width="match_parent" | ||
android:layout_height="wrap_content" | ||
android:layout_marginEnd="@dimen/activity_horizontal_margin" | ||
android:layout_marginStart="@dimen/activity_horizontal_margin" | ||
android:layout_marginTop="@dimen/grid_1"> | ||
android:layout_marginTop="@dimen/grid_1" | ||
android:dropDownVerticalOffset="@dimen/grid_11"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think you'll need this because the drop down list is drawn over the spinner.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good I'll remove it!
What
See 馃憖