change email validation #352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Save button state. Added isValidPassword util.
added local email error.
clearing form and hiding keyboard on save click. alphabetizing VM.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what did i do!
Switched to horizontal progress bar below toolbar.
No longer crashing when user can't connect to the server.
Added back
CustomAdapterforEmailbecause the mutation fails without it.Added
StringUtils. isValidPassword.Added options menu to
ChangeEmailActivitywith save button that is enabled/disabled when input is valid or network call is in progress.Hiding the keyboard when the user clicks save.
Created data class
ChangeEmailso the validation is easier to follow in the view model.Moved the start and end margin to the
TextInputLayoutinstead of theTextInputEditTextso the error is left aligned.Showing error on email input when it loses focus and isn't valid.
Showing error snackbar. (will be restyled in a different PR)
Tests ✨
see