[ENHANCE 馃棧] (Sub)category name on cards #357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DiscoveryAdapter now takes a list of Pair<Project, DiscoveryParams> to check whether project subcategory should be shown. Showing subcategory when not looking at subcategory page. Still need to do Project We Love logic and tests.
Added staffPicks boolean to Project model. Added style for tag text. Added documentation for project card VM. Fixed DiscoveryFragmentViewModelTest. Fixed ProjectCardHolderViewModelTest. Started adding tests for new outputs in ProjectCardHolderViewModelTest.
Rcureton
reviewed
Oct 18, 2018
| @@ -212,6 +216,14 @@ public ViewModel(final @NonNull Environment environment) { | |||
| .subscribe(p -> this.koala.trackViewedUpdate(p, KoalaContext.Update.ACTIVITY_SAMPLE)); | |||
| } | |||
|
|
|||
| private List<Pair<Project, DiscoveryParams>> combineProjectsAndParams(final @NonNull List<Project> projects, final @NonNull DiscoveryParams params) { | |||
| final ArrayList<Pair<Project, DiscoveryParams>> projectAndParams = new ArrayList<>(projects.size()); | |||
| for (int i = 0; i < projects.size(); i++) { | |||
There was a problem hiding this comment.
Haven't used one of these in a while 馃檭
Rcureton
reviewed
Oct 18, 2018
app/src/main/java/com/kickstarter/viewmodels/ProjectCardHolderViewModel.java
Show resolved
Hide resolved
Rcureton
approved these changes
Oct 18, 2018
| this.projectWeLoveIsGone = this.project | ||
| .map(Project::staffPick) | ||
| .compose(coalesce(false)) | ||
| .compose(combineLatestPair(this.discoveryParams.map(DiscoveryParams::staffPicks).compose(coalesce(false)))) |
There was a problem hiding this comment.
Why is the coalese(false) opposed to taking in a value?
There was a problem hiding this comment.
staffPick is @Nullable. If it is null, we want to force it to be false.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
Projects We Lovewhen project is a staff pick but hiding when viewing the staff picks filter.ProjectCardHolderViewModelsince there wasn't anysee
All Projects 聽聽聽聽聽聽聽聽聽聽聽聽 聽聽聽聽聽聽 聽聽聽聽聽聽 聽聽聽聽聽聽 聽聽聽聽聽聽 聽聽聽聽聽聽 聽聽聽聽聽聽 聽聽聽聽聽聽 聽聽聽聽聽聽 Staff Picks/Projects We Love
Root category 聽聽聽聽聽聽聽聽聽聽聽聽 聽聽聽聽聽聽 聽聽聽聽聽聽 聽聽聽聽聽聽 聽聽聽聽聽聽 聽聽聽聽聽聽 聽聽聽聽聽聽 聽聽聽聽聽聽 聽聽聽聽聽聽 Subcategory
Added documentation for
me