Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing broken tests #360

Merged
merged 2 commits into from
Oct 23, 2018
Merged

Fixing broken tests #360

merged 2 commits into from
Oct 23, 2018

Conversation

eoji
Copy link
Contributor

@eoji eoji commented Oct 23, 2018

what

Added helper event clickOnButtonInDialog.
Updated log out test since we now show dialog.
Stopped NewsletterViewModel, NotificationsViewModel, and PrivacyViewModel from emitting a null (logged out) user and crashing the app (which happens when you run the tests and you're not logged in).

@eoji eoji requested a review from Rcureton October 23, 2018 15:54
@eoji eoji merged commit fd07e72 into master Oct 23, 2018
@eoji eoji deleted the io/fixing-settings-test branch October 23, 2018 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants