Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[🚀] Defaulting to recommendations for opted in users #363

Merged
merged 2 commits into from
Oct 26, 2018

Conversation

eoji
Copy link
Contributor

@eoji eoji commented Oct 25, 2018

what

Defaulting Discovery to recommended projects for users who are logged in and opted in.
Also, moving recommendations to the top of the drawer (it wasn't as tricky as I thought 😛).
Added tests for default params for:

  1. logged out users
  2. logged in, opted in users
  3. logged in, opted out users

why

iOS ran an experiment to show Recommendations for logged in users by default instead of All Projects and it was a hit. kickstarter/ios-oss#320

see

image

…recs to the top of the list. Tests tests tests.
Copy link
Contributor

@Rcureton Rcureton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great and you won the vote ⬇️!

@eoji eoji merged commit e33511d into master Oct 26, 2018
@eoji eoji deleted the io/default-recommendations branch October 26, 2018 16:25
@eoji
Copy link
Contributor Author

eoji commented Oct 26, 2018

Turn recommendations on

@pje
Copy link

pje commented Nov 2, 2018

Increase test coverage of payments stripe-elements modules

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants