Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhance] Quick return Discovery CollapsingToolbarLayout #366

Merged
merged 3 commits into from
Oct 30, 2018
Merged

[Enhance] Quick return Discovery CollapsingToolbarLayout #366

merged 3 commits into from
Oct 30, 2018

Conversation

eoji
Copy link
Contributor

@eoji eoji commented Oct 29, 2018

THE CHAMP IS HERE

what

Quick returning the entire Discovery CollapsingToolbarLayout on scroll and stubbornly bringing back the elevation.
Removing the divider line with AlphaBehavior because it's no longer visually relevant when the Appbar is collapsed.

see

device-2018-10-26-165952 2018-10-29 15_29_37

image

@eoji eoji requested a review from Rcureton October 29, 2018 19:34
@eoji
Copy link
Contributor Author

eoji commented Oct 30, 2018

Don't hide discovery header/search/activity bar while scrolling

Rcureton
Rcureton approved these changes Oct 30, 2018
View reviewed changes
Copy link
Contributor

@Rcureton Rcureton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!

@eoji eoji merged commit bd7ff9d into master Oct 30, 2018
@eoji eoji deleted the io/quick-return-appbar branch October 30, 2018 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rcureton Rcureton Rcureton approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@eoji @Rcureton