Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[(∩`-´)⊃━☆゚.*・。゚] Payment methods recycler animations #377

Merged
merged 1 commit into from
Nov 14, 2018

Conversation

eoji
Copy link
Contributor

@eoji eoji commented Nov 13, 2018

what

-Leveraged the new ListAdapter class that handles list changes more responsibly 😛
-When a user adds or deletes a card, we now get these awesome animations for free.

Shoutout to @CDRussell for a great blog post about it: https://medium.com/@trionkidnapper/recyclerview-more-animations-with-less-code-using-support-library-listadapter-62e65126acdb

how

-I didn't want to change KSAdapter because 16 classes extend it and that's not what this feature is about. Maybe for an Investment Day™, I could refactor all of them.
-So! I made a new class called KSListAdapter that extends ListAdapter. It still can handle sections and uses our existing KSViewHolder pattern ٩( ᐛ )و

look how cute

@eoji eoji requested a review from Rcureton November 13, 2018 23:20
@eoji
Copy link
Contributor Author

eoji commented Nov 13, 2018

Deleting card animation

Copy link
Contributor

@Rcureton Rcureton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

image

@eoji eoji merged commit 3bad262 into settings-v3 Nov 14, 2018
@eoji eoji deleted the io/delete-animation branch November 14, 2018 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants