[Enhancement] - Change Settings > Help web views to Chrome Custom Tabs #437
Conversation
Rcureton
changed the title
There was a problem hiding this comment.
The toolbar and status bar are green in my build. Can you please update the screenshots.
These screens are not only used in settings. They're also in the sign up/log in flow and checkout. So right now this feels janky, half open in a custom chrome tab and the other in our custom webview @nnekab @dannyalright.
It also crashes if a user doesn't have a browser that supports custom tabs.
| @@ -85,4 +74,18 @@ class HelpSettingsActivity : BaseActivity<HelpSettingsViewModel.ViewModel>() { | |||
| startActivity(Intent.createChooser(intent, getString(R.string.support_email_chooser))) | |||
| } | |||
| } | |||
|
|
|||
| private fun loadChromePages(endpoint: String) { | |||
There was a problem hiding this comment.
Let's rename this to either startChromeTab or startCustomTab for accuracy.
| builder.setToolbarColor(ContextCompat.getColor(this, R.color.primary)) | ||
|
|
||
| val customTabsIntent = builder.build() | ||
| customTabsIntent.launchUrl(this, Uri.parse(url)) |
There was a problem hiding this comment.
This crashes if the user doesn't have a browser that's capable of handling a custom tabs. I don't think we needed to remove all of that code. We need a fallback.
| terms_of_use.setOnClickListener { | ||
| startActivityWithSlideLeftTransition(Intent(this, HelpActivity.Terms::class.java)) | ||
| } | ||
| cookie_policy.setOnClickListener{ loadChromePages("cookies") } |
There was a problem hiding this comment.
These should be constants. We previously used Secrets.HelpCenter.ENDPOINT and the static classes in HelpActivity
|
Done! |
What ❓
Changed all of the Help links that were previously using
WebViewsand refactored them to usingChromeTabswhich give these links a more native feel and faster loading.Unfortunately Chrome Tabs doesn't support injecting headers as per this article Chrome tabs and headers. Also I referenced the documentation on Chrome tabs and there's nothing for injecting headers as well.
I used this article as a reference for implementation Chrome Custom Tabs
Story 📖
Change Settings > Help web views to Chrome Custom Tabs
See 👀