Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull to refresh on discovery feed #443

Merged
merged 6 commits into from
Jan 24, 2019
Merged

Pull to refresh on discovery feed #443

merged 6 commits into from
Jan 24, 2019

Conversation

eoji
Copy link
Contributor

@eoji eoji commented Jan 24, 2019

What ❓

Pull to the refresh in discovery, with tracking.

Story πŸ“–

Trello

See πŸ‘€

(this screenshot is from 12/14/18 so doesn't have new Material styling)
device-2018-12-14-174910 2018-12-14 18_24_05

Created a swipe refresher for BaseFragments. A little copy pasta.
# Conflicts:
#	app/src/main/java/com/kickstarter/ui/fragments/DiscoveryFragment.java
#	app/src/main/res/layout/fragment_discovery.xml
@eoji eoji requested a review from Rcureton January 24, 2019 16:57
Copy link
Contributor

@Rcureton Rcureton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a revolutionary feature for our app! haha long awaited 🍾

βœ…Tested

  • Tested on Samsung S8 8.0

}

private void setColorSchemeResources(final @NonNull SwipeRefreshLayout layout) {
// Iterate through colors in loading spinner while waiting for refresh
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is pretty cool 😏

@eoji eoji merged commit 69a77e7 into master Jan 24, 2019
@eoji eoji deleted the io/disco-ptr branch January 24, 2019 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants