Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[🚮] Removing deprecated calls to pipeErrorsTo in Reset Password #448

Merged
merged 1 commit into from
Jan 28, 2019

Conversation

eoji
Copy link
Contributor

@eoji eoji commented Jan 25, 2019

What ❓

Transformers.pipeErrorsTo is deprecated. Instead, we should use Observable.materialize and handle the error state and the values state.
Removed deprecated call and changed file spacing for 2 to 4.

how to test ⁉️

Reset password screen successfully:

  • resets password
  • handles a reset attempt made when a user is offline

image

@eoji
Copy link
Contributor Author

eoji commented Jan 25, 2019

Copy link
Contributor

@Rcureton Rcureton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

##✅Tested

  • Samsung s8 8.0

@eoji eoji merged commit 637fcea into master Jan 28, 2019
@eoji eoji deleted the io/request-password-vm-refactor branch January 28, 2019 16:20
@eoji eoji mentioned this pull request Feb 6, 2019
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants