Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement] - Pledge Activity Digest #451

Merged
merged 2 commits into from
Jan 31, 2019
Merged

[Enhancement] - Pledge Activity Digest #451

merged 2 commits into from
Jan 31, 2019

Conversation

Rcureton
Copy link
Contributor

@Rcureton Rcureton commented Jan 28, 2019 •
edited
Loading

What ❓

  • Updated the NotificationsActivity to use the new strings for the creators digest.
  • Removed the mail_icon and notifyOfPostLikes email from the SettingsBody and User models
  • Updated strings from milkrun

Story 📖

Pledge Activity Digest

See 👀

jan-31-2019 14-46-43

@Rcureton Rcureton requested a review from eoji January 28, 2019 18:43
@Rcureton
Copy link
Contributor Author

Pledge Activity Digest

eoji
eoji reviewed Jan 29, 2019
View reviewed changes
Copy link
Contributor

@eoji eoji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had some questions!

How should I be testing this? On web, this is what I see:
screen shot 2019-01-29 at 11 12 05 am

But on the app, I see:

Are we supposed to have the New likes row? Web only has email and not a phone.

@Rcureton
Copy link
Contributor Author

Rcureton commented Jan 29, 2019 •
edited
Loading

Yes we should have the new likes row according to the design. I think the changes being reflected on web should be how we test it.

eoji
eoji approved these changes Jan 31, 2019
View reviewed changes
Copy link
Contributor

@eoji eoji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran it 👀 I'm still confused but it works 👍

@Rcureton Rcureton merged commit 76f426f into master Jan 31, 2019
@Rcureton Rcureton deleted the rc/pledge-activity-digest branch January 31, 2019 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eoji eoji eoji approved these changes

Assignees
No one assigned
Labels
feature ✨
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Rcureton @eoji