[Feature ✨] - Create Password #459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eoji
reviewed
Feb 5, 2019
app/src/main/AndroidManifest.xml
Outdated
| <meta-data | ||
| android:name="com.google.android.gms.wallet.api.enabled" | ||
| android:value="true" /> | ||
|
|
||
| <activity android:name=".ui.activities.CreatePasswordActivity"> |
There was a problem hiding this comment.
Let's alphabetize this and use the settings transitions
| @@ -74,6 +74,11 @@ class LoginActivity : BaseActivity<LoginViewModel.ViewModel>() { | |||
| .compose(observeForUI()) | |||
| .subscribe { showConfirmationSnackbar(login_toolbar, R.string.Got_it_your_changes_have_been_saved) } | |||
|
|
|||
| this.viewModel.outputs.showCreatedPasswordSnackback() | |||
| fun newPassword(newPassword: String) | ||
|
|
||
| /** Call when the user clicks the submit password button. */ | ||
| fun submitPasswordClicked() |
There was a problem hiding this comment.
Let's rename this createPasswordClicked for consistency.
| import rx.subjects.BehaviorSubject | ||
| import rx.subjects.PublishSubject | ||
|
|
||
| const val CREATE_PASSWORD_MINIMUM_LENGTH = 6 |
There was a problem hiding this comment.
We have this value now in 2 places. (The other is ChangePasswordViewModel) Should we just have one constant that lives in StringUtils?
There was a problem hiding this comment.
Yes I agree we should I'll add it to the StringUtils Class.
| @@ -54,6 +54,9 @@ interface LoginViewModel { | |||
| /** Emits when a user has successfully changed their password and needs to login again. */ | |||
| fun showChangedPasswordSnackbar(): Observable<Void> | |||
|
|
|||
| /** Emits when a user has successfully created their psssword and needs to login again. */ | |||
| fun showCreatedPasswordSnackback(): Observable<Void> | |||
| @@ -54,6 +54,9 @@ interface LoginViewModel { | |||
| /** Emits when a user has successfully changed their password and needs to login again. */ | |||
| fun showChangedPasswordSnackbar(): Observable<Void> | |||
|
|
|||
| /** Emits when a user has successfully created their psssword and needs to login again. */ | |||
|
|
||
| <TextView | ||
| android:id="@+id/create_password_text_view" | ||
| style="@style/TextInputPasswordLayout" |
There was a problem hiding this comment.
I don't think this is the right style.
# Conflicts: # app/src/main/AndroidManifest.xml # app/src/main/java/com/kickstarter/mock/services/MockApolloClient.kt # app/src/main/java/com/kickstarter/services/ApolloClientType.kt # app/src/main/java/com/kickstarter/services/KSApolloClient.kt # app/src/main/java/com/kickstarter/ui/activities/AccountActivity.kt
eoji
approved these changes
Feb 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❓
AccountActivityand you don't have a password you will see theCreate Accountrow. If you do have a password you will see theChange EmailandChange Passwordrows.Story 📖
Create Password
Create Password Event
See 👀
How to QA
Please refer to Trello description for testing instructions.