Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] fixed the delay in the pledge activity digest spinner #467

Merged
merged 1 commit into from
Feb 7, 2019
Merged

[Bug] fixed the delay in the pledge activity digest spinner #467

merged 1 commit into from
Feb 7, 2019

Conversation

Rcureton
Copy link
Contributor

@Rcureton Rcureton commented Feb 7, 2019

What ❓

  • Paired with @eoji on fixing the delay in the NotificationsActivity it was due the emissions of the userInput and userOutput being in separate observables.

How to QA? 🤔

Upon deselecting 'Project activity' if I have 'Daily summary' as my chosen value, the spinner will first change from 'Daily summary' to 'Twice a day summary', then close. If I re-enable 'Project activity', it will start from 'Twice a day summary'.

  • It should now just collapse the spinner without changing the values.

See 👀

pledge-fix

@Rcureton Rcureton requested review from eoji and dnywh February 7, 2019 16:52
eoji
eoji approved these changes Feb 7, 2019
View reviewed changes
Copy link
Contributor

@eoji eoji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since i worked on this....I APPROVE

@eoji eoji added the bug 🐛 label Feb 7, 2019
@Rcureton Rcureton changed the title fixed the delay in the notifications screen [Bug] fixed the delay in the pledge activity digest spinner Feb 7, 2019
@Rcureton Rcureton merged commit f13ce6e into master Feb 7, 2019
@Rcureton Rcureton deleted the rc/pledge-activity-delay branch February 7, 2019 18:34
@dnywh
Copy link
Contributor

dnywh commented Feb 7, 2019

nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eoji eoji eoji approved these changes

@dnywh dnywh Awaiting requested review from dnywh

Assignees
No one assigned
Labels
bug 🐛
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Rcureton @dnywh @eoji