Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Koala Settings Event Name Update #468

Merged
merged 6 commits into from
Feb 12, 2019
Merged

Koala Settings Event Name Update #468

merged 6 commits into from
Feb 12, 2019

Conversation

Rcureton
Copy link
Contributor

@Rcureton Rcureton commented Feb 7, 2019 •
edited
Loading

What ❓

  • Apparently the event name we were using for Settings was deprecated so I updated it to the new event name.
  • Also added the tracking events for Payment Methods they were there just not wired up. Added them to the tests as well.

@Rcureton Rcureton requested a review from eoji February 7, 2019 21:08
@eoji
Copy link
Contributor

eoji commented Feb 11, 2019

I'm not sure what deprecated means so can you please confirm we need one and not both?

@Rcureton
Copy link
Contributor Author

@eoji So I confirmed with @peat for this PR that we can fully deprecate Settings View since the rest of the organization isn't using it to track anything.

eoji
eoji approved these changes Feb 12, 2019
View reviewed changes
Copy link
Contributor

@eoji eoji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job on the tests!!
I think I found an unrelated bug though 🤔

@Rcureton Rcureton merged commit 3077bf2 into master Feb 12, 2019
@Rcureton Rcureton deleted the rc/settings-tracking branch February 12, 2019 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eoji eoji eoji approved these changes

Assignees
No one assigned
Labels
maintenance 🗜
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Rcureton @eoji