Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drawer divider and header updates #470

Merged
merged 8 commits into from
Feb 8, 2019
Merged

Drawer divider and header updates #470

merged 8 commits into from
Feb 8, 2019

Conversation

eoji
Copy link
Contributor

@eoji eoji commented Feb 8, 2019 •
edited
Loading

What ❓

  • Drawer divider went from .5dp to 1 dp
  • Added HeaderViewHolder to support headers in the drawer.

Story 📖

Trello

before and after 👀

@eoji eoji added the UI 🎨 label Feb 8, 2019
@eoji eoji requested a review from dnywh February 8, 2019 20:11
@dnywh
Copy link
Contributor

dnywh commented Feb 8, 2019

nice! Are the type styles in HeaderViewHolder fixed? If not, could you please set the font weight to 'regular'? It more closely resembles the Material spec.

@eoji
[skip ci] Merge branch 'master' into io/drawer-dividers-headers-update
a69252d 
# Conflicts:
#	app/src/main/res/layout/discovery_drawer_logged_out_view.xml
@eoji eoji merged commit 90e73b1 into master Feb 8, 2019
@eoji eoji deleted the io/drawer-dividers-headers-update branch February 8, 2019 22:17
@eoji
Copy link
Contributor Author

eoji commented Feb 12, 2019

Improve navigation and filtering on Android app

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dnywh dnywh dnywh approved these changes

Assignees
No one assigned
Labels
Investment Day! 💰 UI 🎨
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@eoji @dnywh