Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logged in drawer updates #471

Merged
merged 8 commits into from
Feb 8, 2019
Merged

Logged in drawer updates #471

merged 8 commits into from
Feb 8, 2019

Conversation

eoji
Copy link
Contributor

@eoji eoji commented Feb 8, 2019

What ❓

  • making avatar 48 by 48
  • making name bigger

Story πŸ“–

Trello

before and after πŸ‘€

@eoji eoji requested a review from dnywh February 8, 2019 20:24
@dnywh
Copy link
Contributor

dnywh commented Feb 8, 2019

killing it! One tweak: could you please increase the distance from the top of the screen to the header avatar?

  • Between top-of-header-avatar and system bar: 16dp (or 18 if you want to use our grid)
  • Between top-of-header-avatar and top-of-screen: 40dp (or 42 if you want to use our grid)

@eoji
Copy link
Contributor Author

eoji commented Feb 8, 2019

That space is 16dp, my avi has a white background so it's hard to see
screen shot 2019-02-08 at 5 12 47 pm

# Conflicts:
#	app/src/main/res/layout/discovery_drawer_header.xml
@eoji eoji merged commit b0d5895 into master Feb 8, 2019
@eoji eoji deleted the io/logged-in-header-updates branch February 8, 2019 22:26
@eoji
Copy link
Contributor Author

eoji commented Feb 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants