Drawer item updates #472
Merged
Drawer item updates #472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # app/src/main/res/layout/discovery_drawer_header.xml
dnywh
reviewed
Feb 8, 2019
app/src/main/res/values/colors.xml
Outdated
| <color name="blue_darken_10">@color/ksr_cobalt_600</color> | ||
| <color name="gray_alpha_50">@color/ksr_grey_300</color> | ||
| <color name="gray_darken_10">@color/ksr_grey_500</color> | ||
| <color name="green_alpha_20">#33037362</color> | ||
| <color name="green_alpha_50">#80037362</color> | ||
| <color name="green_alpha_18">#2e009E74</color> |
There was a problem hiding this comment.
My bad; I've realised that green_alpha_18 is not accessible with our primary green as text on top of it. Could we please make and use green_alpha_10 instead?
Changed vertical spacing of drawer items to 15dp.
|
thanks for fixing! I'm also noticing that the green background tint doesn't have a matching margin from the right-side of the drawer. As in it's horizontally uneven. Not important enough to hold merge though, I reckon. |
|
It's 6dp on both sides 🕵️♀️ |
|
my mistake—didn't take into account the gutter GitHub puts in between images |
dnywh
approved these changes
Feb 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❓
Styled:
Story 📖
Trello
before and after 👀