Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated copy for Creator Notifications #473

Merged
merged 6 commits into from
Feb 11, 2019
Merged

Conversation

Rcureton
Copy link
Contributor

What ❓

  • Updated strings from master and updated copy in the notification screen

Story 📖

Updated copy for Creator Notifications

See 👀

creator_notif

@Rcureton Rcureton requested a review from eoji February 11, 2019 16:37
@Rcureton
Copy link
Contributor Author

@eoji
Copy link
Contributor

eoji commented Feb 11, 2019

why were the Italian strings removed?

@Rcureton
Copy link
Contributor Author

I ran into an issue with the Italian Strings in Circle earlier. Then I read back in Slack about the translations with Italian and Chinese. I reverted the changes and they're passing in Circle now.

@Rcureton Rcureton merged commit c320042 into master Feb 11, 2019
@Rcureton Rcureton deleted the rc/creator-notification-copy branch February 11, 2019 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants