Discovery user refresh bug 🐜 #476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rrentUser` emitted. We really only care if the user changes.
Rcureton
approved these changes
Feb 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❓
I was going to open another PR but then I noticed, if you're logged in, looking at a category in Discovery and you leave that screen, Discovery shows the default params (recommended if you’re opted in or all projects). This PR fixes the bug that causes Discovery to show default params every time
currentUseremits. We really only care if the user changes (shoutout to my friendchangedUser#224).How to QA? 🤔
In Discovery, view a category or top filter that's not your default. Trigger a user refresh; you can open up settings or open up a different app. When you return, you should see the category/top filter you previously chose.
currently in prod
the fix