Settings transitions #477
Merged
Settings transitions #477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…verride exitTransition everywhere. Changed Discovery -> Settings transition to slide up.
This feels a bit jarring to me. Agreed with the sentiment, though. How about we remove the transition completely? The Drawer -> Section transition (instantaneous, in this suggestion) should occur before the drawer closes. Gmail on Android is a good example of this. |
|
Gmail is using Fragments, since we're using Activities, it's not possible (we're going from 1 screen with a drawer to a new one). Here's what it looks like with no transition: |
|
Gotcha. The Activities no-transition still feels less interruptive to me—at
least in that GIF format.
…On Tue, Feb 12, 2019 at 5:06 PM Izzy Oji ***@***.***> wrote:
Gmail is using Fragments, since we're using Activities, it's not possible
(we're going from 1 screen with a drawer to a new one). Here's what it
looks like with no transition:
[image: device-2019-02-12-170149 2019-02-12 17_06_10]
<https://user-images.githubusercontent.com/1289295/52671235-8333a100-2ee8-11e9-9a49-903013669ebc.gif>
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#477 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AC9f-f4ro4MJPskZz8A77eBZ8mYzIPChks5vMzrogaJpZM4a4GTX>
.
|
Rcureton
approved these changes
Feb 13, 2019
| <style name="SettingsActivityTransitions" parent="android:style/Animation.Activity"> | ||
| <item name="android:activityOpenEnterAnimation">@anim/settings_slide_in_from_bottom</item> | ||
| <item name="android:activityOpenExitAnimation">@null</item> | ||
| <item name="android:activityCloseEnterAnimation">@null</item> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❓
Created standard style
SettingsActivityfor settings transitions so we don't need to overrideexitTransitioneverywhere.Removed Discovery -> Settings transition.
Story 📖
Trello
See 👀
From Discovery
Top Level Settings
Account & Payment methods
(change email is omitted from gif on purpose)
Notifications
