Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Japanese Yen string update #506

Merged
merged 2 commits into from Apr 3, 2019
Merged

Japanese Yen string update #506

merged 2 commits into from Apr 3, 2019

Conversation

eoji
Copy link
Contributor

@eoji eoji commented Apr 2, 2019

What ❓

Updated the strings, most notably, "¥ Japanese Yen (JPY)".

Story 📖

Trello Story

See 👀

@eoji eoji requested a review from Scollaco April 2, 2019 14:51
@eoji
Copy link
Contributor Author

eoji commented Apr 2, 2019

[JP] Change copy "Yen (JPY)" to "Japanese Yen (JPY)" in currency selection menu

@eoji eoji requested a review from Rcureton April 3, 2019 17:09
Rcureton
Rcureton approved these changes Apr 3, 2019
View reviewed changes
Copy link
Contributor

@Rcureton Rcureton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

##✅Tested

  • G2G

@eoji eoji merged commit fd8953c into master Apr 3, 2019
@eoji eoji deleted the io/update-strings branch April 3, 2019 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rcureton Rcureton Rcureton approved these changes

@Scollaco Scollaco Awaiting requested review from Scollaco

Assignees
No one assigned
Labels
maintenance 🗜
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@eoji @Rcureton