Fixing bug with android pay button #507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What β
In this huge PR #427, I added TWO (?!?!)
WalletFragments.I got rid of the second one π
How Sway?!
I inspected the layout π
I initially thought it was in the toolbar but really it was floating on top ΰΌΌ ΰΌΰΊΆ ΰ·΄ ΰΌΰΊΆΰΌ½ We got around this with the first fragment by setting its height and width to
0dp.How to QA? π€
Try to pledge to a project!
The screen should no longer show that ghost button.
Story π
Trello Story
See π
(These are Stripe test cards)
