[💳] Unavailable cards in pledge screen #579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cepted for a project's currency. Added StoredCard.usdCardTypes and nonUsdCardTypes but will be replaced by API. RewardCardAdapter now takes in a project so the cards can be disabled if they're not accepted. Disabling non accepted cards in PledgeFragment. Added button_select for a disablable soft black button. Updated card expiration copy. Manually added Not available string because I am impatient. Tests.
Scollaco
approved these changes
Aug 7, 2019
app/src/main/java/com/kickstarter/viewmodels/RewardCardViewHolderViewModel.kt
Show resolved
Hide resolved
app/src/test/java/com/kickstarter/viewmodels/RewardCardViewHolderViewModelTest.kt
Outdated
Show resolved
Hide resolved
| } | ||
|
|
||
| @Test | ||
| fun testButtonCTA_whenCardNotAccepted() { |
There was a problem hiding this comment.
Same here testButtonCTATitle_when...
app/src/test/java/com/kickstarter/viewmodels/RewardCardViewHolderViewModelTest.kt
Outdated
Show resolved
Hide resolved
| } | ||
|
|
||
| @Test | ||
| fun testNotAvailableCopyIsVisible_whenCardIsNotAccepted() { |
There was a problem hiding this comment.
And here testNotAvailableCopyIsVisible_isTrue_when...
# Conflicts: # app/src/main/java/com/kickstarter/viewmodels/PledgeFragmentViewModel.kt # app/src/test/java/com/kickstarter/viewmodels/PledgeFragmentViewModelTest.kt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📲 What
Disabling ineligible cards (based on project currency) in pledge screen.
🤔 Why
So users can't pledge with cards that aren't accepted.
🛠How
ProjectUtils.acceptedCardTypeto determine whether a card is accepted for a project's currency.StoredCard.usdCardTypesandnonUsdCardTypesbut will be replaced by API.RewardCardAdapternow also takes in a project so the cards can be disabled if they're not accepted.button_select.xmlfor a disablable soft black button.Not availablestring because I am impatient.👀 See
📋 QA
Note: The v1 API does not return a project's localized country name so I'm just using
project.location.displayableNamebecause I can only work with what I have.🇺🇸 All cards should be available for projects that are in USD.
🚫🇺🇸 Non USD projects only allow AMEX™, Mastercard™, and Visa™
Story 📖
Trello Story