[🔁] Cancel Pledge redesign

[eoji]

📲 What

Implementation of the cancel pledge redesign.

🤔 Why

Redesign™

🛠 How

• Changed background color to ksr_grey_300.
• Removed toolbar.
• The pledge amount and project name are now bold.
• There were some BehaviorSubjects that should've been PublishSubjects, you know how it goes.
• It now animates horizontally, instead of vertically.

👀 See

After 🦋	Before 🐛

📋 QA

Notes 2 u, the QA individual:
1️⃣ Tertiary (gray) buttons are ksr_grey_400 and not ksr_grey_500 so it does not match the Abstract.
2️⃣ Outlined text fields do not have a fill. We can switch to the filled text fields if desired.
3️⃣ Regression test: you should still be able to cancel your pledge or dismiss the screen.

Story 📖

https://dripsprint.atlassian.net/browse/NT-200

[oliverswitzer]

🍿

<3 functions as first class citizens in Kotlin! 🎆

[oliverswitzer]

Ah ok so at this point formatted string already has the data interpolated, and using SpannableString is really just to add bold-ness to the string for the amount and name of the project, right?

I'm getting it!

[oliverswitzer]

...I think

[eoji]

yes!

[oliverswitzer]

This looks great! Out of curiosity, what was the reason behind changing over to a BehaviorSubject for progressBarIsVisible and PublishSubject for the showCancelError and showServerError? Does it have to do with the fact that we no longer have a close button on the new version of this screen?

(also apologies for the delay between making comments and approving, had to hop into a meeting)

[eoji]

Hey @oliverswitzer, np!!

So, a PublishSubject is a special type of Observable that when it's subscribed to, it will only emit new emissions.

Compared to a BehaviorSubject. A BehaviorSubject is a special type of Observable that when it's subscribed to, it will emit its last emission and any new emissions.

So you want to use a BehaviorSubject when you want the VM to maintain that state (say like when you're rotating your phone!) and a PublishSubject when that state is ephemeral. Using the CancelPledgeFragmentViewModel as an example, if we were showing a ProgressBar, we still want to show it after a rotation. For an error, we just want to show it once, and not repeat it if the user rotated their phone.