convert id to string in project page view model

kickstarter · Dec 4, 2023 · 0e58684 · 0e58684
1 parent 4f645e8
commit 0e58684
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 7 deletions.
diff --git a/Kickstarter-iOS/Features/ProjectPage/Controller/ProjectPageViewController.swift b/Kickstarter-iOS/Features/ProjectPage/Controller/ProjectPageViewController.swift
@@ -744,7 +744,7 @@ public final class ProjectPageViewController: UIViewController, MessageBannerVie
   private func presentBlockUserAlert(username: String, userId: Int) {
     let alert = UIAlertController
       .blockUserAlert(username: username, blockUserHandler: { _ in
-        self.viewModel.inputs.blockUser(id: "\(userId)")
+        self.viewModel.inputs.blockUser(id: userId)
       })
 
     self.present(alert, animated: true)

diff --git a/Library/ViewModels/ProjectPageViewModel.swift b/Library/ViewModels/ProjectPageViewModel.swift
@@ -11,7 +11,7 @@ public protocol ProjectPageViewModelInputs {
   func applicationDidEnterBackground()
 
   /// Call when block user is tapped
-  func blockUser(id: String)
+  func blockUser(id: Int)
 
   /// Call with the project given to the view controller.
   func configureWith(projectOrParam: Either<Project, Param>, refTag: RefTag?)
@@ -506,7 +506,7 @@ public final class ProjectPageViewModel: ProjectPageViewModelType, ProjectPageVi
     self.goToURL = self.didSelectCampaignImageLinkProperty.signal.skipNil()
 
     let blockUserEvent = self.blockUserProperty.signal
-      .map(BlockUserInput.init(blockUserId:))
+      .map { BlockUserInput.init(blockUserId: "\($0)") }
       .switchMap { input in
         AppEnvironment.current.apiService
           .blockUser(input: input)
@@ -531,8 +531,8 @@ public final class ProjectPageViewModel: ProjectPageViewModelType, ProjectPageVi
     self.applicationDidEnterBackgroundProperty.value = ()
   }
 
-  fileprivate let blockUserProperty = MutableProperty<String>("")
-  public func blockUser(id: String) {
+  fileprivate let blockUserProperty = MutableProperty<Int>(0)
+  public func blockUser(id: Int) {
     self.blockUserProperty.value = id
   }
 

diff --git a/Library/ViewModels/ProjectPageViewModelTests.swift b/Library/ViewModels/ProjectPageViewModelTests.swift
@@ -330,7 +330,7 @@ final class ProjectPageViewModelTests: TestCase {
       self.didBlockUser.assertValueCount(0)
       self.didBlockUserError.assertValueCount(0)
 
-      self.vm.inputs.blockUser(id: "\(User.template.id)")
+      self.vm.inputs.blockUser(id: User.template.id)
 
       self.scheduler.advance()
 
@@ -355,7 +355,7 @@ final class ProjectPageViewModelTests: TestCase {
       self.didBlockUser.assertValueCount(0)
       self.didBlockUserError.assertValueCount(0)
 
-      self.vm.inputs.blockUser(id: "\(User.template.id)")
+      self.vm.inputs.blockUser(id: User.template.id)
 
       self.scheduler.advance()