[WEB-697] Adds new Facebook Login Deprecation feature flag (#1715)

* Adds new Facebook Login Deprecation feature flag * Updates snapshot reference image for tests
kickstarter · Aug 31, 2022 · 31562b1 · 31562b1
1 parent faa5d78
commit 31562b1
Show file tree

Hide file tree

Showing 8 changed files with 31 additions and 4 deletions.
diff --git a/Kickstarter-iOS/Views/Controllers/OptimizelyFeatureFlagToolsViewControllerTests.swift b/Kickstarter-iOS/Views/Controllers/OptimizelyFeatureFlagToolsViewControllerTests.swift
@@ -23,7 +23,8 @@ final class OptimizelyFeatureFlagToolsViewControllerTests: TestCase {
       |> \.features .~ [
         OptimizelyFeature.commentFlaggingEnabled.rawValue: false,
         OptimizelyFeature.projectPageStoryTabEnabled.rawValue: false,
-        OptimizelyFeature.rewardLocalPickupEnabled.rawValue: false
+        OptimizelyFeature.rewardLocalPickupEnabled.rawValue: false,
+        OptimizelyFeature.facebookLoginDeprecationEnabled.rawValue: false
       ]
 
     withEnvironment(language: .en, mainBundle: MockBundle(), optimizelyClient: mockOptimizelyClient) {

diff --git a/Library/OptimizelyClientTypeTests.swift b/Library/OptimizelyClientTypeTests.swift
@@ -24,7 +24,7 @@ final class OptimizelyClientTypeTests: TestCase {
         OptimizelyFeature.commentFlaggingEnabled.rawValue: true
       ]
 
-    XCTAssert(mockOptimizelyClient.allFeatures().count == 4)
+    XCTAssert(mockOptimizelyClient.allFeatures().count == 5)
   }
 
   func testVariantForExperiment_NoError() {

diff --git a/Library/OptimizelyFeature+Helpers.swift b/Library/OptimizelyFeature+Helpers.swift
@@ -27,3 +27,10 @@ public func featurePaymentSheetEnabled() -> Bool {
     (AppEnvironment.current.optimizelyClient?
       .isFeatureEnabled(featureKey: OptimizelyFeature.paymentSheetEnabled.rawValue) ?? false)
 }
+
+public func facebookLoginDeprecationEnabled() -> Bool {
+  return AppEnvironment.current.userDefaults
+    .optimizelyFeatureFlags[OptimizelyFeature.facebookLoginDeprecationEnabled.rawValue] ??
+    (AppEnvironment.current.optimizelyClient?
+      .isFeatureEnabled(featureKey: OptimizelyFeature.facebookLoginDeprecationEnabled.rawValue) ?? false)
+}
diff --git a/Library/OptimizelyFeature+HelpersTests.swift b/Library/OptimizelyFeature+HelpersTests.swift
@@ -74,4 +74,13 @@ final class OptimizelyFeatureHelpersTests: TestCase {
       XCTAssertFalse(featurePaymentSheetEnabled())
     }
   }
+
+  func testFacebookDeprecation_Optimizely_FeatureFlag_False() {
+    let mockOptimizelyClient = MockOptimizelyClient()
+      |> \.features .~ [OptimizelyFeature.facebookLoginDeprecationEnabled.rawValue: false]
+
+    withEnvironment(optimizelyClient: mockOptimizelyClient) {
+      XCTAssertFalse(facebookLoginDeprecationEnabled())
+    }
+  }
 }
diff --git a/Library/OptimizelyFeature.swift b/Library/OptimizelyFeature.swift
@@ -5,6 +5,7 @@ public enum OptimizelyFeature: String, CaseIterable {
   case projectPageStoryTabEnabled = "project_page_v2_story"
   case rewardLocalPickupEnabled = "ios_local_pickup"
   case paymentSheetEnabled = "ios_payment_sheet"
+  case facebookLoginDeprecationEnabled = "ios_facebook_deprecation"
 }
 
 extension OptimizelyFeature: CustomStringConvertible {
@@ -14,6 +15,7 @@ extension OptimizelyFeature: CustomStringConvertible {
     case .projectPageStoryTabEnabled: return "Project Page Story Tab"
     case .rewardLocalPickupEnabled: return "Local Pickup Rewards"
     case .paymentSheetEnabled: return "Payment Sheet"
+    case .facebookLoginDeprecationEnabled: return "Facebook Login Deprecation"
     }
   }
 }
diff --git a/Library/ViewModels/OptimizelyFeatureFlagToolsViewModel.swift b/Library/ViewModels/OptimizelyFeatureFlagToolsViewModel.swift
@@ -104,6 +104,9 @@ private func getValueFromUserDefaults(for feature: OptimizelyFeature) -> Bool? {
   case .paymentSheetEnabled:
     return AppEnvironment.current.userDefaults
       .optimizelyFeatureFlags[OptimizelyFeature.paymentSheetEnabled.rawValue]
+  case .facebookLoginDeprecationEnabled:
+    return AppEnvironment.current.userDefaults
+      .optimizelyFeatureFlags[OptimizelyFeature.facebookLoginDeprecationEnabled.rawValue]
   }
 }
 
@@ -123,5 +126,8 @@ private func setValueInUserDefaults(for feature: OptimizelyFeature, and value: B
   case .paymentSheetEnabled:
     return AppEnvironment.current.userDefaults
       .optimizelyFeatureFlags[OptimizelyFeature.paymentSheetEnabled.rawValue] = value
+  case .facebookLoginDeprecationEnabled:
+    return AppEnvironment.current.userDefaults
+      .optimizelyFeatureFlags[OptimizelyFeature.facebookLoginDeprecationEnabled.rawValue] = value
   }
 }
diff --git a/Library/ViewModels/OptimizelyFeatureFlagToolsViewModelTests.swift b/Library/ViewModels/OptimizelyFeatureFlagToolsViewModelTests.swift
@@ -25,7 +25,8 @@ final class OptimizelyFlagToolsViewModelTests: TestCase {
         OptimizelyFeature.commentFlaggingEnabled.rawValue: true,
         OptimizelyFeature.projectPageStoryTabEnabled.rawValue: true,
         OptimizelyFeature.rewardLocalPickupEnabled.rawValue: true,
-        OptimizelyFeature.paymentSheetEnabled.rawValue: true
+        OptimizelyFeature.paymentSheetEnabled.rawValue: true,
+        OptimizelyFeature.facebookLoginDeprecationEnabled.rawValue: true
       ]
 
     withEnvironment(optimizelyClient: mockOptimizelyClient) {
@@ -47,7 +48,8 @@ final class OptimizelyFlagToolsViewModelTests: TestCase {
         OptimizelyFeature.commentFlaggingEnabled.rawValue: false,
         OptimizelyFeature.projectPageStoryTabEnabled.rawValue: false,
         OptimizelyFeature.rewardLocalPickupEnabled.rawValue: false,
-        OptimizelyFeature.paymentSheetEnabled.rawValue: false
+        OptimizelyFeature.paymentSheetEnabled.rawValue: false,
+        OptimizelyFeature.facebookLoginDeprecationEnabled.rawValue: false
       ]
 
     withEnvironment(optimizelyClient: mockOptimizelyClient) {

diff --git a/...lagToolsViewControllerTests/testOptimizelyFeatureFlagToolsViewController@2x.png b/...lagToolsViewControllerTests/testOptimizelyFeatureFlagToolsViewController@2x.png