[NT-1240] Prevent UIStackViews from inheriting margins (#1192)

* Add insetsLayoutMarginsFromSafeArea = false

* Set additional insetsLayoutMarginsFromSafeArea to false

* Removing unneeded insetsLayoutMarginsFromSafeArea

* Removing push file

Co-authored-by: Isabel Barrera <ifbarrera@me.com>

Kickstarter-iOS/Views/Cells/PledgePaymentMethodCell.swift

@@ -64,9 +64,7 @@ final class PledgePaymentMethodCell: UITableViewCell, ValueCell {
 
     NSLayoutConstraint.activate([
       self.cardImageView.widthAnchor.constraint(equalToConstant: Styles.grid(10)),
-      self.checkmarkImageView.widthAnchor.constraint(
-        equalTo: self.cardImageView.widthAnchor, multiplier: 0.4
-      ),
+      self.checkmarkImageView.widthAnchor.constraint(equalToConstant: Styles.grid(4)),
       self.checkmarkImageView.heightAnchor.constraint(equalTo: self.cardImageView.heightAnchor)
     ])
   }
@@ -93,10 +91,9 @@ final class PledgePaymentMethodCell: UITableViewCell, ValueCell {
       |> labelsStackViewStyle
 
     _ = self.cardImageAndLabelsStackView
-      |> checkoutAdaptableStackViewStyle(
+      |> cardImageAndLabelsStackViewStyle(
         self.traitCollection.preferredContentSizeCategory.isAccessibilityCategory
       )
-      |> adaptableStackViewStyle
 
     _ = self.unavailableCardTypeLabel
       |> unavailableCardTypeLabelStyle
@@ -177,6 +174,14 @@ private let adaptableStackViewStyle: StackViewStyle = { stackView in
     |> \.spacing .~ Styles.grid(2)
 }
 
+private func cardImageAndLabelsStackViewStyle(_ isAccessibilityCategory: Bool) -> StackViewStyle {
+  return { stackView in
+    stackView
+      |> checkoutAdaptableStackViewStyle(isAccessibilityCategory)
+      |> adaptableStackViewStyle
+  }
+}
+
 private let checkmarkImageViewStyle: ImageViewStyle = { imageView in
   imageView
     |> \.contentMode .~ .center
@@ -212,6 +217,7 @@ private let rootStackViewStyle: StackViewStyle = { stackView in
     |> \.axis .~ .horizontal
     |> \.layoutMargins .~ .init(all: Styles.grid(2))
     |> \.isLayoutMarginsRelativeArrangement .~ true
+    |> \.insetsLayoutMarginsFromSafeArea .~ false
     |> \.spacing .~ Styles.grid(2)
 }
 

Kickstarter-iOS/Views/Cells/PledgePaymentMethodLoadingCell.swift

@@ -64,14 +64,22 @@ final class PledgePaymentMethodLoadingCell: UITableViewCell, ValueCell {
     _ = self.rootStackView
       |> \.spacing .~ Styles.grid(2)
       |> \.isLayoutMarginsRelativeArrangement .~ true
+      |> \.insetsLayoutMarginsFromSafeArea .~ false
       |> \.layoutMargins .~ .init(all: Styles.grid(2))
 
     _ = self.contentStackView
       |> \.axis .~ .vertical
       |> \.distribution .~ .fillEqually
       |> \.spacing .~ Styles.gridHalf(3)
       |> \.isLayoutMarginsRelativeArrangement .~ true
+      |> \.insetsLayoutMarginsFromSafeArea .~ false
       |> \.layoutMargins .~ .init(topBottom: Styles.grid(1))
+
+    _ = self.subtitleStackView
+      |> \.insetsLayoutMarginsFromSafeArea .~ false
+
+    _ = self.titleStackView
+      |> \.insetsLayoutMarginsFromSafeArea .~ false
   }
 
   func configureWith(value _: Void) {}

Kickstarter-iOS/Views/Controllers/PledgeAmountViewController.swift

@@ -144,7 +144,7 @@ final class PledgeAmountViewController: UIViewController {
       }
   }
 
-  override func didMove(toParent parent: UIViewController?) {
+  override func didMove(toParent _: UIViewController?) {
     self.verticalSpacer.isHidden = true
   }